[Fiber] Make requestIdleCallback() and requestAnimationFrame() shims async#8591
Merged
gaearon merged 4 commits intofacebook:masterfrom Dec 21, 2016
Merged
[Fiber] Make requestIdleCallback() and requestAnimationFrame() shims async#8591gaearon merged 4 commits intofacebook:masterfrom
gaearon merged 4 commits intofacebook:masterfrom
Conversation
They no longer need to be sync in tests because we already made DOM renderer sync by default. This fixes a crash when testing incrementalness in DOM renderer itself.
gaearon
changed the title
acdlite
approved these changes
Dec 17, 2016
| callback({ timeRemaining() { return Infinity; } }); | ||
| setTimeout(() => { | ||
| callback({ timeRemaining() { return Infinity; } }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Not that it really matters but
setTimeout(callback, 0, { timeRemaining() { return Infinity; } });would save an allocation :)
Collaborator
Author
There was a problem hiding this comment.
Today I learned. I don't care though—it's tests. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They no longer need to be sync in tests because we already made DOM renderer sync by default.
This fixes a crash when testing incrementalness in DOM renderer itself.